Comments for mwu's blog http://blog.mozilla.org/mwu A tale of a fearless coder Thu, 29 Sep 2011 22:20:40 +0000 hourly 1 http://wordpress.org/?v=3.5.1 Comment on mozilla-central: Now with 88.7% less PRBool! by Robert O'Callahan http://blog.mozilla.org/mwu/2011/09/29/mozilla-central-now-with-88-7-less-prbool/comment-page-1/#comment-41 Robert O'Callahan Thu, 29 Sep 2011 22:20:40 +0000 http://blog.mozilla.org/mwu/?p=83#comment-41 OK, what’s next? :-)

]]> Comment on mozilla-central: Now with 88.7% less PRBool! by Arpad Borsos http://blog.mozilla.org/mwu/2011/09/29/mozilla-central-now-with-88-7-less-prbool/comment-page-1/#comment-40 Arpad Borsos Thu, 29 Sep 2011 12:55:14 +0000 http://blog.mozilla.org/mwu/?p=83#comment-40 Awesome!
Now I need to run my dehydra script again to see how this affected the alignment of structs and probably save some more bytes here and there…

]]> Comment on The Twelve Booleans of Mozilla by Taras’ Blog » Blog Archive » Effective Static Analysis http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-39 Taras’ Blog » Blog Archive » Effective Static Analysis Thu, 04 Aug 2011 04:27:56 +0000 http://blog.mozilla.org/mwu/?p=69#comment-39 [...] Wu’s boolcheck tool is awesome. He wrote it to check that “typedef int” bools are really being used as [...]

]]> Comment on The Twelve Booleans of Mozilla by mwu http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-37 mwu Sun, 31 Jul 2011 00:38:31 +0000 http://blog.mozilla.org/mwu/?p=69#comment-37 Good question.

The problem is that the only easy rewriting case is the case where it doesn’t matter. The bool type automatically converts non-zero values to 1, so surrounding every non-boolean expr with !!(expr) doesn’t buy you anything after switching PRBool to bool. Then, for the cases where PRBool isn’t the type the code should be using, there’s a judgement call about what type to use instead and if the code needs other fixes.

I’ll try to elaborate on this in a future post.

]]> Comment on The Twelve Booleans of Mozilla by Chad http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-36 Chad Sat, 30 Jul 2011 15:20:48 +0000 http://blog.mozilla.org/mwu/?p=69#comment-36 Do the changes have to be manual? Couldn’t the plug-in rewrite the expressions too?

]]> Comment on The Twelve Booleans of Mozilla by Benoit Jacob http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-35 Benoit Jacob Sat, 30 Jul 2011 06:52:15 +0000 http://blog.mozilla.org/mwu/?p=69#comment-35 Very old GCC versions had sizeof(bool)==4. I concur that all current compilers seem to be using sizeof(bool)==1 but that would at least require a test (like a static assertion) before it’d be comfortable relying on.

]]> Comment on The Twelve Booleans of Mozilla by mwu http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-34 mwu Fri, 29 Jul 2011 23:55:57 +0000 http://blog.mozilla.org/mwu/?p=69#comment-34 I’m not. I’m only changing Mozilla bool types where we have control over. However, it needs to be on the list of boolean types for this analysis to work out.

Coincidentally, I haven’t seen a platform where bool isn’t 8bit wide yet.

]]> Comment on The Twelve Booleans of Mozilla by Benoit Jacob http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-33 Benoit Jacob Fri, 29 Jul 2011 19:01:23 +0000 http://blog.mozilla.org/mwu/?p=69#comment-33 Don’t touch realGLboolean!! OpenGL relies on its sizeof being 1, which bool doesn’t guarantee.

]]> Comment on The Twelve Booleans of Mozilla by mwu http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-32 mwu Fri, 29 Jul 2011 15:53:21 +0000 http://blog.mozilla.org/mwu/?p=69#comment-32 Getting rid of JSBool and JSPackedBool would be nice too, though that’s a bit more difficult than PRBool and PRPackedBool.

A few of the other boolean types are used in C where there is inconsistent support for bool – VC doesn’t support it.

]]> Comment on The Twelve Booleans of Mozilla by John Drinkwater http://blog.mozilla.org/mwu/2011/07/28/the-twelve-booleans-of-mozilla/comment-page-1/#comment-31 John Drinkwater Fri, 29 Jul 2011 14:01:16 +0000 http://blog.mozilla.org/mwu/?p=69#comment-31 So afterwards, they’re just 10 boolean types left?

]]>