Acid2!
8 December 2006This morning DBaron checked the reflow branch into the trunk. This is a pretty major step forward for the layout engine that will ship in Firefox3. In David’s words the goals of the reflow refactoring are:
* simplification of code
* fixing incremental reflow (“{inc}”) bugs
* fixing intrinsic sizing bugs
* allowing better integration of nsIBox and nsIFrame layout
* allowing easier implementation of new features like ‘inline-block’
This also means the current trunk passes Acid2:
This is the reference image:
And – here’s how Firefox2 fares:
Big congrats to David for all the hard work here – not to mention Bz for doing the reviews and a ton of other folks who helped test, review, setup tinderboxes, etc. In case you are wondering – he’s what marking a bug of this magnitude fixed looks like:
10 Responses to “Acid2!”
December 8th, 2006 at 10:07 pm
Whooboy, that’s something to see.
December 8th, 2006 at 10:14 pm
A hearty congratulations!
I noticed how damn quick the wiki articles http://en.wikipedia.org/wiki/Acid2 and http://en.wikipedia.org/wiki/Features_of_Mozilla_Firefox were changed
December 8th, 2006 at 11:35 pm
That’s just awesome
Good work, people!
December 9th, 2006 at 5:39 am
Good news! Great work!!
The position of the nose is slightly (about 1px) off. To see it, quickly tab forward and backward between both the reference image and trunk’s rendering.
December 9th, 2006 at 5:42 pm
Yeah…
it’s one pixel right and one pixel down.
But, anyway, I’m too happy to bother.
This 1px problem probably is simple to fix.
December 11th, 2006 at 6:50 am
nice work
hope it will be integrated in FF!!!
December 11th, 2006 at 11:06 am
The issue with the nose looks similar to: http://weblog.timaltman.com/node/802
December 13th, 2006 at 4:29 am
It’s OK for the position of the nose to be slightly different than in the reference rendering. IIRC, this is because the exact “position” of the nose is due to the order in which borders are drawn, which isn’t specified by CSS.
January 3rd, 2007 at 11:37 am
Congratulations! Stuff like this is why it’s so fun to use Minefield Trunk builds.
March 9th, 2007 at 9:37 pm
great work! so this will solve some bugs that are open since 2002 (5 years!) such as issues like
Splitting Absolutely positioned frames not implemented – Missing second page of content when printing or print previewing this site
https://bugzilla.mozilla.org/show_bug.cgi?id=154892
?
sounds like the community are really wanting basic features like printing to work correctly