Comments on: Nicely rewriting outparams

By: tglek

tglek — Fri, 11 May 2007 21:51:42 +0000

Fixing the naming convention is pretty easy. Maintaining indentation is harder(once more code moves around), but doable.

By: Johnny Stenback

Johnny Stenback — Fri, 11 May 2007 21:49:00 +0000

One note, the patch in question generates changes that replace an out param with a local variable with the same name. There’s a naming convention that conflicts with this, which is that arguments are named ‘a’ followed by something, and something is camel cased (i.e. first character upper cased, etc).

Seems reasonably straight forward to auto-rename to strip off the ‘a’ and lowercase the following character. Or would that be hard?

By: tglek

tglek — Fri, 11 May 2007 15:27:17 +0000

Thanks. Looks like we can’t do an automatic rewrite if a function already uses null/not-null in the outparam for a special meaning. That’s why I made selecting candidates & rewriting separate stages. This way a human can check/trim the list of candidates and rerun the tool as many times as needed and when it is most convenient.

By: Neil

Neil — Fri, 11 May 2007 11:48:24 +0000

Note that the very first example in the diff is incorrect – CreateHTMLImageFrame has three possible return conditions, a) no frame necessary b) frame created succesfully c) failed to create frame.