How to get reviews fast: Delete Code!
March 31st, 2010 by tglek
The fastest review I ever got was when I deleted a bunch of code from libjar. It was so riddled crud it was next to impossible to modify the code. That was a mere 24KB patch produced manually.
Ehren just put my personal records to shame with a 94KB patch that got r+ed at breakneck speed. Best part is that he generates these by plucking off dead parts of the Mozilla callgraph via static analysis. I bet if he tried he could land 90KB patches every day. Way to go Ehren!
I expect more good code deletions to make themselves known via this meta bug.
2 Responses to “How to get reviews fast: Delete Code!”
But not everybody seems to be willing to sacrifice theoretical compatibility (see bug 230675). Mozilla is going nowhere fast if that’s the general attitude…
That bug’s disagreement wasn’t about compatibility, it was about maintainability, a rather different holdup.