Comments on: Faster Plugin Enumeration + Help Wanted

By: Miroslav

Miroslav — Fri, 31 Dec 2010 13:19:28 +0000

I really rest when it comes to run vtune at work. The problem typically is to set up useful and measurable experiment (program run).

I think if you post or otherwise publish cases where “beating under-performing code” is really needed some people may do it as part of their hobby. Of course if they could get to it through myriad of obstacles in a weekend. Last time I checked ff code infrastructure looked quite monstrous though.

By: tglek

tglek — Thu, 30 Dec 2010 23:00:34 +0000

Alfred,
I reviewed the patch in 617897

bug 405407 does seem relevant and it’s too bad it wasn’t picked up in time for ff4. I see no reason to not review/land that asap once ff4 branches.

The rest of the patches appear to be waiting for your input so they can progress.

By: Dan

Dan — Thu, 30 Dec 2010 13:55:51 +0000

I think 11736 should be 511736 in the previous comment.

Keep up the good work, I hope you get some good applicants.

By: Alfred Kayser

Alfred Kayser — Thu, 30 Dec 2010 13:00:09 +0000

Does this focus to the Core performance now also mean that bugs including patches for Core performance optimization will get reviewed now?

For example:
313282 In strcstr.c there is an ‘obvious improvement’ waiting to be performed
456547 Only create the offline cache when really needed
490700 Let qcms directly transform to Cairo pixel format to save later conversions
11736 nsJARInputStream.cpp: release dependency on nsJar when doing directory read
417154 nsMemoryCacheDevice::EvictEntriesIfNecessary could be optimized
331032 Decom nsICacheEntryInfo, replace by ExpirationTime attribute to nsICachingChannel
230675 ‘decom’ of nsICacheVisitor.idl: saves 10% / 150K from nkcache_s.lib
399223 make aToken a member of nsCSSScanner instead of passing as function argument
617897 Replace calls to AppendASCII(‘*’) with Append(‘*’)
405407 Merge nsDiskCacheStreamIO and nsDiskCacheStreamOutput

I also have submitted a patch to optimize nsDirEnum itself somewhat (saving a NEW and string copies).

By: Neil Rashbrook

Neil Rashbrook — Thu, 30 Dec 2010 11:35:56 +0000

Does this mean that extensions can drop all their ABI-specific plugins (e.g. Linux_x86-gcc3 and Linux_x86_64-gcc3) into the main extension plugin folder and this will just work? (Platform-specific plugin folders got dropped in bug 568691).

By: Sid

Sid — Thu, 30 Dec 2010 04:52:36 +0000

Hooray for fixing this! The delays can even sometimes be of the order of 20 seconds or above — pretty crazy.

By: SuperPutte

SuperPutte — Thu, 30 Dec 2010 01:57:03 +0000

Hi Tara!
Finally Mozilla can see this problem…. great idea to hire one or two guys dedicated to solve it.
I hope you find your hAcKerz
Thanks!