{"id":436,"date":"2015-04-27T11:41:35","date_gmt":"2015-04-27T15:41:35","guid":{"rendered":"http:\/\/blog.mozilla.org\/nfroyd\/?p=436"},"modified":"2015-04-27T11:41:35","modified_gmt":"2015-04-27T15:41:35","slug":"recent-tsan-improvements-for-firefox","status":"publish","type":"post","link":"https:\/\/blog.mozilla.org\/nfroyd\/2015\/04\/27\/recent-tsan-improvements-for-firefox\/","title":{"rendered":"recent tsan improvements for firefox"},"content":{"rendered":"

One of my goals for Q2 was to make Firefox usable with “modern” (version 3.6+) clang. For reasons previously unknown, Firefox would only work with relatively old clang (version ~3.3); indeed, our wiki page for TSan<\/a> recommends checking out specific SVN versions!<\/p>\n

I’m happy to say that goal has been met.\u00a0 If you like, you can read (some of) the gory details in bug 1153244<\/a>.\u00a0 Checking out a development version of Clang and building that should enable you to test Firefox (from mozilla-central<\/a>, since that’s where the aforementioned bug has landed thus far) with TSan.\u00a0 Upgrading through several major releases has its benefits: TSan appears to be somewhat more stable—tests that would previously timeout reliably now run without complaint.\u00a0 I’m not sure that it’s quite reliable enough to run in automation yet, but running TSan tests in automation is definitely more feasible than it was last quarter.<\/p>\n

With an eye towards doing that, and also with an eye towards improving individual developer experience, I’ve recently landed several patches that teach our test harnesses about TSan-specific things.\u00a0 For instance, when we’re running mochitests<\/a>, we only care about races in the browser itself; we don’t care about races while running any of the supporting tools (particularly xpcshell,<\/code> which shares a lot of code with the browser through libxul).\u00a0 So TSan should only be enabled for the actual browser executable.\u00a0 We already do similar things for our ASan builds.<\/p>\n

I also discovered that my local builds weren’t using the llvm-symbolizer<\/code> tool<\/a> to produce backtraces in TSan’s reports, but instead defaulting to using addr2line<\/code>.\u00a0 addr2line<\/code> is a fine tool, but llvm-symbolizer<\/code> understands debug information better (for instance, it shows you synthesized frames for inlined functions, which is a huge win) and llvm-symbolizer<\/code> is somewhat faster than addr2line<\/code>. In my case, it was a combination of llvm-symbolizer<\/code> not being in my PATH<\/code>, and not informing TSan about the location of llvm-symbolizer<\/code> ($OBJDIR\/dist\/bin\/<\/code>, usually). The former was addressed by setting LLVM_SYMBOLIZER<\/code> in my mozconfig (not necessary if llvm-symbolizer<\/code> is on your PATH<\/code>), and the latter was addressed by adding a bit of code to our test scripts.<\/p>\n

Now, to update the wiki with better instructions!<\/p>\n","protected":false},"excerpt":{"rendered":"

One of my goals for Q2 was to make Firefox usable with “modern” (version 3.6+) clang. For reasons previously unknown, Firefox would only work with relatively old clang (version ~3.3); indeed, our wiki page for TSan recommends checking out specific SVN versions! I’m happy to say that goal has been met.\u00a0 If you like, you […]<\/p>\n","protected":false},"author":320,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[5,72430],"_links":{"self":[{"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/posts\/436"}],"collection":[{"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/users\/320"}],"replies":[{"embeddable":true,"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/comments?post=436"}],"version-history":[{"count":0,"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/posts\/436\/revisions"}],"wp:attachment":[{"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/media?parent=436"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/categories?post=436"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blog.mozilla.org\/nfroyd\/wp-json\/wp\/v2\/tags?post=436"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}