I would like to see Firefox developers switch to 24hour review turn-around times. Note that in my definition review turn-around means any of the following:
- unset/reassign r? to someone else
It is ridiculous in our recent faster release cycle if a patch takes half (or more) of the cycle loitering in the review queue. I believe that a shorter review cycle is the simplest way to accelerate Firefox evolution.
I view fast review times as a matter of respect. Posting a patch usually requires a significant time/effort commitment, reviewers should act appropriately. There is no bigger buzzkill than having your work pushed back to the bottom of somebody’s TODO list like some annoying chore.
As far as I can tell there are 3 main reasons* that lead to long review times:
1) People like gavin, bz, dbaron having disproportionally high review loads. We need a process to hand-off patches to other reviewers. High-load people shouldn’t shy away from passing on the r? to someone else when possible.
2) Bugzilla-fobic people (like myself) loosing track of bugzilla r? requests due to not having bugzilla whines setup. Bugzilla whines should be enabled by default.
3) Bad review habits. I met a number of Mozilla developers that like to batch their reviews up and then do them all on a single weekday. Please stop, you are killing all kinds of coding momentum/fun/etc.Lets make it our policy to set aside time every day to clear the review queue.
Clearly people with existing backlogs will take a while to catch up, but most MoCo employees should be capable of this.
I have yet to hear a good reason against doing daily reviews.
It has been a few months since I proposed this on dev.platform. I have tried to live by the 24hour rule, I think a few others tried this too. I find that morning bugzilla r? whines work best for me. I still occasionally loose track of a patch for a few days, but nobody is perfect. I think people appreciate fast reviews, but nobody thanked me yet.
Dec 6 Update: My goal is to have *some* response within 24hours with an ETA for next followup in the worst case.