Tomcat's Blog

Sheriffing @ Mozilla – checkin-needed

January 26th, 2017 by cbook

Hi,

Working as Sheriff @ Mozilla is much more than just monitoring our trees and doing things like backouts. In 2017 i wanted to start to blog more about what we do and here is:

Part 1 – Checkin-needed

A lot of checkins land everyday on the Mozilla repositories. Some are great new features and improvements and some are bugfixes of existing bugs etc.

While a lot of checkins are done by the developers themselves, also sheriffs are involved in this.

We not only monitor the Mozilla repositories (aka the tree) we also do checkins for people who don’t have the appropriate level of permission to check in changes (for example new community members).

In the past checkin-needed was used by developers to reduce load on our build systems with fewer pushes but with a more robust build system this isn’t relevant anymore.

So checkin-needed is more and more important for developers without access-levels to do commits and, as mentioned, new community members who for example finished their first patch.

To request checkin-needed people use this keyword in Bugzilla or use the [checkin-needed-beta] or [checkin-needed-aurora] whiteboard entry for the patches in a bug.

For me personal is checkin-needed a very important task because you sometime check in a patch from someone who just started to contribute to Mozilla. So you are one of the people that are the first contacts to the new contributor and you help them getting the patch landed. That‘s also a good opportunity to say “thanks for contributing to Mozilla” to the new community member, this is great motivation and recognition!

How we work :

We have a wiki page with a bug query and some basic information for the Sheriff on Duty [1]. We use this query to get a overview what bugs need checkins.

For bugs with a patch attached that is not on mozreview we check the checkin-neeed request for:

-> Has proper review before doing anything else

-> Has a successful try run to avoid any bustage on checkin

and land the patch on mozilla-inbound.

For bugs with patches in mozreview we use the autoland tool to do the checkins.

However we still check if the bug has review and check the try run.

This is the preferred way of doing checkin-neededs since autoland is an automated system.

How can you help

-> Use Mozreview – Autoland – it helps us to do more checkins in less time due to the automated tasks. Please make sure that there are no open issues in Mozreview when you request checkin-needed. In fact, you can land them yourself with autoland. In the future, checkin-needed will only be allowed on security bugs.

-> Make sure that you have a passing try run. It is a waste of the sheriffs time to come look at a checkin-needed and it has failures in the try run.

-> When you have multiple patches that need to land and the patches need to land in a specific order – please make a comment in the bug with the correct order.

-> When there are dependencies with other bugs – please state this in the bug.

We try to do checkin-needed checks and checkins several times a day depending on sheriff workload etc so we cannot guarantee a turnaround time but trying to do our best.

When you have feedback/suggestions or idea how to do this task better let us know anytime!

Also as every part of the Mozilla Project we also depend on Community Members like you! So if you are interested to be become a Community Sheriff let me know!

Cheers,

– Tomcat

[1] https://wiki.mozilla.org/Sheriffing/How:To:Landing_checkin-needed_patches

This entry was posted on Thursday, January 26th, 2017 at 2:53 am and is filed under sheriffing. You can follow any responses to this entry through the RSS 2.0 feed. You can leave a response, or trackback from your own site.

166 Responses to “Sheriffing @ Mozilla – checkin-needed”

Use Proxies Says:
February 22nd, 2020 at 12:16 pm
Use Proxies

I found a great…
Hank Sarjeant Says:
February 23rd, 2020 at 5:23 am
Hank Sarjeant

I found a great…
Dante Goss Says:
February 23rd, 2020 at 8:27 am
Dante Goss

I found a great…
Adelaide Bezak Says:
April 2nd, 2020 at 2:24 am
Adelaide Bezak

I found a great…
Tracey Mizwicki Says:
April 2nd, 2020 at 4:38 am
Tracey Mizwicki

I found a great…
Chieko Cleveland Says:
April 2nd, 2020 at 4:45 am
Chieko Cleveland

I found a great…
Isobel Thaxton Says:
April 2nd, 2020 at 6:29 am
Isobel Thaxton

I found a great…
Cheap Proxies Says:
April 7th, 2020 at 11:47 am
Cheap Proxies

I found a great…
Buy Fast Proxy Says:
April 7th, 2020 at 3:59 pm
Buy Fast Proxy

I found a great…
Anibal Talford Says:
April 13th, 2020 at 8:37 am
Anibal Talford

I found a great…
Piedad Philipps Says:
April 21st, 2020 at 9:19 am
Piedad Philipps

I found a great…
Fred Schuerholz Says:
April 21st, 2020 at 9:23 am
Fred Schuerholz

I found a great…
Keren Raggs Says:
May 5th, 2020 at 1:44 pm
Keren Raggs

I found a great…
Buy Cheap Private Proxy Says:
May 7th, 2020 at 7:32 am
Buy Cheap Private Proxy

I found a great…
Proxies For Youtube Says:
May 7th, 2020 at 9:50 am
Proxies For Youtube

I found a great…
Shaquana Blankley Says:
June 10th, 2020 at 3:07 am
Shaquana Blankley

I found a great…
Clay Machalek Says:
June 10th, 2020 at 3:46 am
Clay Machalek

I found a great…
Joleen Pruyne Says:
June 12th, 2020 at 6:56 am
Joleen Pruyne

I found a great…
Synthia Castellari Says:
June 24th, 2020 at 2:43 pm
Synthia Castellari

I found a great…
Leon Hickock Says:
July 23rd, 2020 at 11:30 am
Leon Hickock

I found a great…
Deangelo Latassa Says:
August 5th, 2020 at 7:49 am
Deangelo Latassa

I found a great…
Carlton Quain Says:
August 10th, 2020 at 9:53 am
Carlton Quain

I found a great…
jeremi sitorus Says:
August 21st, 2020 at 1:43 am
I found a great…
Pirkti Zidini Says:
October 6th, 2020 at 8:24 am
Pirkti Zidini

I found a great…
Marcus Rusboldt Says:
October 7th, 2020 at 4:11 am
Marcus Rusboldt

I found a great…
Cheap Usa Proxy Says:
October 7th, 2020 at 7:07 am
Cheap Usa Proxy

I found a great…
Neal Shauer Says:
December 8th, 2020 at 11:54 am
Neal Shauer

I found a great…
Kathey Renzelman Says:
December 24th, 2020 at 3:17 pm
Kathey Renzelman

I found a great…
Buy Best Proxies Says:
December 29th, 2020 at 6:03 am
Buy Best Proxies

I found a great…
Rupert Dominik Says:
December 30th, 2020 at 12:54 am
Rupert Dominik

I found a great…
Monroe Luton Says:
January 4th, 2021 at 7:20 am
Monroe Luton

I found a great…
Free Private Proxies Says:
January 5th, 2021 at 2:21 pm
Free Private Proxies

I found a great…
Buy Cheap Proxies Says:
January 6th, 2021 at 3:05 am
Buy Cheap Proxies

I found a great…
Benton Parma Says:
January 6th, 2021 at 4:05 pm
Benton Parma

I found a great…
Delmar Webb Says:
January 7th, 2021 at 6:52 am
Delmar Webb

I found a great…
Buy Fast Private Proxies Says:
January 11th, 2021 at 4:31 am
Buy Fast Private Proxies

I found a great…
buy us proxy list Says:
January 11th, 2021 at 1:34 pm
buy us proxy list

I found a great…
best proxies for sneaker bots Says:
January 11th, 2021 at 3:14 pm
best proxies for sneaker bots

I found a great…
Claud Adragna Says:
January 13th, 2021 at 7:50 am
Claud Adragna

page-description
Liliana Ebia Says:
January 13th, 2021 at 8:14 am
Liliana Ebia

I found a great…
Alberto Willmert Says:
January 14th, 2021 at 8:26 am
Alberto Willmert

I found a great…
Frida Johanek Says:
January 14th, 2021 at 8:39 am
Frida Johanek

I found a great…
Allan Vollenweider Says:
January 15th, 2021 at 9:20 am
Allan Vollenweider

I found a great…
Lacey Shawn Says:
January 24th, 2021 at 1:06 pm
Lacey Shawn

I found a great…
Tequila Weenum Says:
January 26th, 2021 at 9:20 pm
Tequila Weenum

I found a great…
Cheap Facebook Page Likes Says:
January 31st, 2021 at 8:51 pm
Cheap Facebook Page Likes

I found a great…
Boost Youtube Plays Says:
February 1st, 2021 at 9:38 am
Boost Youtube Plays

I found a great…
Best Facebook Marketing Says:
February 7th, 2021 at 7:11 am
Best Facebook Marketing

I found a great…
Buy Cheap Youtube Services Says:
February 7th, 2021 at 11:43 am
Buy Cheap Youtube Services

I found a great…
Proxies Buy Says:
March 29th, 2021 at 9:47 am
Proxies Buy

I found a great…

Sheriffing @ Mozilla – checkin-needed

166 Responses to “Sheriffing @ Mozilla – checkin-needed”

Leave a Reply