{"id":481,"date":"2017-01-26T02:53:47","date_gmt":"2017-01-26T10:53:47","guid":{"rendered":"http:\/\/blog.mozilla.org\/tomcat\/?p=481"},"modified":"2017-01-26T02:54:53","modified_gmt":"2017-01-26T10:54:53","slug":"sheriffing-mozilla-checkin-needed","status":"publish","type":"post","link":"https:\/\/blog.mozilla.org\/tomcat\/2017\/01\/26\/sheriffing-mozilla-checkin-needed\/","title":{"rendered":"Sheriffing @ Mozilla – checkin-needed"},"content":{"rendered":"
Hi,<\/div>\n
<\/div>\n
Working as Sheriff @ Mozilla is much more than just monitoring our trees and doing things like backouts. In 2017 i wanted to start to blog more about what we do and here is:<\/div>\n
<\/div>\n
Part 1 – Checkin-needed<\/u><\/b><\/span><\/div>\n
<\/div>\n
A lot of checkins land everyday on the Mozilla <\/span>r<\/span>epositories. Some are great new features and improvements and some are bugfixes of existing bugs etc.<\/span><\/div>\n
<\/div>\n
While a lot of checkins are done by the developer<\/span>s<\/span> the<\/span>mse<\/span>lves<\/span>, also <\/span>s<\/span>heriffs are involved in this.<\/span><\/div>\n
<\/div>\n
We not only monitor the Mozilla <\/span>r<\/span>epositor<\/span>ies<\/span> (aka the tree) we also do checkins for people who don’t<\/span> have<\/span> the appropriate level <\/span>of <\/span>permission to check<\/span> in changes<\/span> (<\/span>for<\/span> example new <\/span>c<\/span>ommunity <\/span>m<\/span>embers).<\/span><\/div>\n
<\/div>\n
In the past checkin-needed was used by developers to reduce load on our build<\/span> systems with fewer pushes but with a more robust build system this isn’t relevant anymore.\u00a0<\/span><\/div>\n
<\/div>\n
So checkin-needed is more and more important for developers without access-levels to do commits and<\/span>,<\/span> as mentioned<\/span>,<\/span> new community members who <\/span>for<\/span> example finished their first patch.<\/span><\/div>\n
<\/div>\n
To request checkin-needed people use this keyword in <\/span>B<\/span>ugzilla or use the [checkin-needed-beta] or [checkin-needed-aurora] whiteboard entry for the patches in a bug.<\/span><\/div>\n
<\/div>\n
For me personal is checkin-needed a very important task because you sometime check<\/span> in a patch from someone who just started to contribute to Mozilla. So you are one of the people that are the first contacts to the new contribut<\/span>o<\/span>r and you help <\/span>them <\/span>getting the patch landed. That<\/span>‘<\/span>s also a good opportunity to say “thanks for contributing to <\/span>M<\/span>ozilla” to the new community member, this is great motivation and recognition!\u00a0<\/span><\/div>\n
<\/div>\n
How we work :<\/b><\/span><\/div>\n
\u00a0\u00a0\u00a0\u00a0<\/span><\/div>\n
We have a wiki page with a <\/span>b<\/span>ug <\/span>q<\/span>uery and some basic information for the Sheriff on Duty [1]<\/a>. We use this query to get a overview what <\/span>b<\/span>ugs need checkins.<\/span><\/div>\n
<\/div>\n
For <\/span>b<\/span>ugs with a patch attached that is not <\/span>on <\/span>mozreview we check the checkin-neeed request for:<\/span><\/div>\n
\u00a0\u00a0\u00a0 -> Has proper review before doing anything else<\/span><\/div>\n
\u00a0\u00a0\u00a0 -> Has a successful try run to avoid any bustage on checkin<\/span><\/div>\n
<\/div>\n
and land the patch on mozilla-inbound.<\/span><\/div>\n
<\/div>\n
For <\/span>b<\/span>ugs with patches in mozreview we use the autoland tool to do the checkins.\u00a0<\/span><\/div>\n
However we still check if the bug has review and check the try run.<\/span><\/div>\n
<\/div>\n
This is the prefer<\/span>r<\/span>ed way of doing checkin-neededs since autoland is a<\/span>n<\/span> automated system.<\/span><\/div>\n
<\/div>\n
<\/div>\n
How can you help\u00a0<\/b><\/span><\/div>\n
<\/div>\n
\n