{"id":318,"date":"2018-08-06T16:42:13","date_gmt":"2018-08-06T16:42:13","guid":{"rendered":"https:\/\/blog.mozilla.org\/webrtc\/?p=318"},"modified":"2019-03-11T18:59:52","modified_gmt":"2019-03-11T18:59:52","slug":"getstats-isremote-66","status":"publish","type":"post","link":"https:\/\/blog.mozilla.org\/webrtc\/getstats-isremote-66\/","title":{"rendered":"isRemote in getStats() will disappear in Firefox 66"},"content":{"rendered":"

Are you using getStats()<\/code><\/a> for remote statistics in Firefox? Look for this warning today in Firefox Nightly (63, not 66):<\/p>\n

\u26a0 Detected soon-to-break getStats() use! stat.isRemote goes away in Firefox 66, but won’t warn there!
\n<\/span><\/p>\n

TL;DR:<\/strong> If you see this warning in web console, read on to act now. Firefox 66 will move remote stats to \"remote-outbound-rtp\"<\/code> and \"remote-inbound-rtp\"<\/code>, and isRemote<\/code> will disappear, to comply with a change to the spec<\/a>.<\/p>\n

Firefox 63-65 will warn about this, but for technical reasons Firefox 66 will not be able to. This is because once the stats move in 66, there’s really no way to detect that you intended to look for remote stats the old way.<\/p>\n

Update:<\/strong> The original article said Firefox 55. We’ve pushed it back to Firefox 66, giving you a little more time!<\/em><\/p>\n

<\/p>\n

Here’s a an example of bad isRemote usage<\/a> that triggers this warning in Firefox Nightly (open the web console<\/a> to see the warning).<\/p>\n

What is one to do? Prepare today! There’s already a safe, spec-supported way<\/em> to access remote stats in Firefox that won’t break in Firefox 66: Use remoteId<\/code> to cross-reference<\/em> remote stats from local stats:<\/p>\n

Use remoteId safely today<\/h2>\n

Access remote stats the way we’ve demonstrated in two<\/a> blog posts<\/a> last year, using remoteId<\/code>:<\/p>\n

      const stats = await pc.getStats();\r\n      for (const stat of stats.values()) {\r\n        if (stat.isRemote) continue;\r\n        switch (stat.type) {\r\n          case \"outbound-rtp\"<\/span>: {\r\n            console.log(\"Sent \"<\/span> + stat.bytesSent);\r\n            const remote = stats.get(stat.remoteId); \/\/ <-- Like this!<\/span>\r\n            if (remote) console.log(\"Other side \"<\/span> + remote.bytesReceived);\r\n            break;\r\n          }\r\n          case \"inbound-rtp\"<\/span>: {\r\n            console.log(\"Received \"<\/span> + stat.bytesReceived);\r\n            const remote = stats.get(stat.remoteId); \/\/ <-- Like this!<\/span>\r\n            if (remote) console.log(\"Other side \"<\/span> + remote.bytesSent);\r\n            break;\r\n          }\r\n       }\r\n<\/pre>\n
This code enumerates local stats, and finds the corresponding remote stat at the same time, using the remoteId<\/code> cross-reference.This is just as fast as other ways of obtaining this information, as it merely cross-references into the same already-returned RTCStatsReport<\/code> object.<\/p>\n
Organizationally, this keeps related data together, and this approach will continue to work today, tomorrow in Firefox 66, and beyond. It should also work in Chrome once it supports remote stats in its spec API (it doesn’t today).<\/p>\n
But…<\/h3>\n
Look carefully, and you’ll see we’re still using isRemote<\/code> above in one place! Specifically:<\/p>\n
      if (stat.isRemote) continue;<\/span>\r\n<\/span><\/pre>\n
This is not a mistake. This is needed for compatibility, or we’d mistake remote stats for local stats in today’s browsers, where they’re listed under the same type. This will continue to work in Firefox 66 where isRemote<\/code> will be undefined<\/code>, because that works out to the same as false<\/code> in that if<\/code>-statement.<\/p>\n
The warnings in Nightly are clever enough not to trip over this use. Instead, they trigger on any access of actual remote statistics, if it hasn’t seen use of .get(remoteId)<\/code> first.<\/p>\n
Don’t be like this:<\/h2>\n
The other way to read remote stats today is to check isRemote<\/code> for true. This will break<\/strong><\/em> in Firefox 66:<\/p>\n
      const stats = await pc.getStats();\r\n      for (const stat of stats.values()) {\r\n        switch (stat.type) {\r\n          case \"outbound-rtp\"<\/span>: {\r\n            if (stat.isRemote) {                           \/\/ always undefined!<\/span>\r\n              console.log(\"Other side \"<\/span> + stat.bytesSent); \/\/ never runs!<\/span>\r\n            } else {\r\n              console.log(\"Sent \"<\/span> + stat.bytesSent);       \/\/ wrong!<\/span>\r\n            }\r\n            break;\r\n          }\r\n          case \"inbound-rtp\"<\/span>: {\r\n            if (stat.isRemote) {                               \/\/ always undefined!<\/span>\r\n              console.log(\"Other side \"<\/span> + stat.bytesReceived); \/\/ will never run!<\/span>\r\n            } else {\r\n              console.log(\"Received \"<\/span> + stat.bytesReceived);   \/\/ wrong!<\/span>\r\n            }\r\n            break;\r\n          }\r\n       }\r\n<\/pre>\n
In the future:<\/h2>\n
For completeness, we should mention that once Firefox 66 is out, you could also write the following, but it won’t work in older versions,<\/em> obviously, because \"remote-inbound-rtp\"<\/code> and \"remote-outbound-rtp\"<\/code> won’t exist in those browsers:<\/p>\n
      const stats = await pc.getStats();\r\n      for (const stat of stats.values()) {\r\n        switch (stat.type) {\r\n          case \"outbound-rtp\"<\/span>: {\r\n            console.log(\"Sent \"<\/span> + stat.bytesSent);\r\n            break;\r\n          }\r\n          case \"remote-inbound-rtp\"<\/span>: {\r\n            console.log(\"Other side \"<\/span> + stat.bytesReceived);\r\n            break;\r\n          }\r\n          case \"inbound-rtp\"<\/span>: {\r\n            console.log(\"Received \"<\/span> + stat.bytesReceived);\r\n            break;\r\n          }\r\n          case \"remote-outbound-rtp\"<\/span>: {\r\n            console.log(\"Other side \"<\/span> + stat.bytesSent);\r\n            break;\r\n          }\r\n       }\r\n<\/pre>\n
In addition to not working in older browsers, this approach has other downsides: According to the spec, stats may appear in any order, which means this example might print the log statements in any order, and not grouped together logically. For these two reasons, we recommend you stick with the remoteId<\/code> example. In the future, should you at some point no longer care about older versions, you can simply drop the following line from it:<\/p>\n
      if (stat.isRemote) continue;<\/span>\r\n<\/pre>\n
Working Good Example<\/h2>\n
Here’s the remoteId<\/code> approach again in a working example. Hit the “Result” tab to see it in action: