Warnings-as-errors in js/src/, take 2

I recently wrote that we changed the way the JavaScript shell was built so that it would treat compiler warnings as errors.  Unfortunately, we had to back it out.  It was working fine on common configurations, particularly those that are part of our standard tinderbox testing, but it was causing too much breakage for people using unusual configurations.

Then Paul Biggar suggested a lovely compromise of adding a special build to the standard tinderbox testing of TraceMonkey.  That way, we’d know about compiler warnings on the most important platforms.  Phil Ringnalda went and implemented the idea with some help from Chris Atlee, and now we have a warnings-as-errors build (under “SM (e)”):

SM (e) build on TBPL

Amazing enough, it was green on its first run.

Thanks guys!  This build is currently only showing up on Phil’s development version of TBPL, it’ll make it onto the official TBPL sometime soon.

And now I wonder if something similar could be done for whole-browser builds…

Correctness Tinderbox


I landed a TraceMonkey patch yesterday that was completely green on the tinderbox pushlog:

All green TBPL!

I don’t think that’s ever happened to me before.  Even the full tinderbox was completely green except for a single burning N810 Talos column.

I pushed another patch afterwards, that one didn’t get all green 🙁