Sheriffing@Mozilla – Sheriffing and Backouts

April 3rd, 2017 by cbook

Hi,

Keeping the code trees [1] green (meaning free of build or test failures,
regressions, and minimizing intermittent test failures) is the daily
goal of sheriffing.

In order to reach this goal, this means we sometimes have to back out (revert)
changes made by developers. While this is a part of our job, we don’t do
it easily or without reason.

Backouts happen mostly for:
-> Bustage (i.e. Firefox no longer
successfully builds)
-> Test failures caused by a specific change
-> Issues reported by the community, like startup crashes or severe
regressions (these backouts often lead to new nightly builds being
created as well)
-> Performance regressions or memory leaks
-> Issues that block merges like merge-conflicts (like for a mozilla-inbound to mozilla-central merge)

For our primary integration repositories (where our developers land most
their changes), our workflow depends on which repository the problem is
on.

Mozilla-Inbound

-> Close Mozilla-Inbound if needed (preventing
developers from landing any further changes until the problem is
resolved)

-> Try to notify the responsible developer so that they
are  aware of the problem caused by their patch

-> If possible, we
accept follow-up patches to fix the problem. This allows us to fail
forward and avoid running extra jobs that require more CPU time and
therefore increase costs.

-> If we don’t get response from the developer within a short
timeframe like 5 minutes, we back out the change and comment in the
bug with a reason for the backout (for example, including a link to the
failure log) and a needinfo to the assigne, to make sure the bug don’t get lost.

Autoland

-> Changesets that cause problems are backed out immediately –
no follow-ups as described above are possible (only the sheriffs can push manually to
autoland)

In any case, backouts are never meant to be personal and it’s part of
our job to try our best to keep our trees open for developers. We also
try to provide as much information as possible in the bug for why we
backed out a change.

Of course, we also make mistakes and it could be that we backed out
changesets that were innocent (like in a case where its not 100% clear
what caused the problem), but we try our best.

If you feedback or ideas how we can make things better, let me know.

Cheers,
– Tomcat

 

[1] Trees: The tree contains the source code as well as the code required to build each project on supported platforms (Linux, Windows, macOS, etc) and tests for various areas. Sheriffs take care of Firefox Code Trees like mozilla-central, mozilla-inbound, autoland, mozilla-aurora, mozilla-beta and mozilla-esr45/52 – our primary tool is treeherder and can be found here

614 Responses to “Sheriffing@Mozilla – Sheriffing and Backouts”

  1. Jess Prete Says:

    Jess Prete

    I found a great…

  2. Ashanti Juckett Says:

    Ashanti Juckett

    I found a great…

  3. Conrad Hargett Says:

    Conrad Hargett

    I found a great…

  4. Kira Macnab Says:

    Kira Macnab

    I found a great…

  5. Morton Topacio Says:

    Morton Topacio

    I found a great…

  6. laser hair removal Says:

    Right here is the perfect webpage for everyone whoo wants to understand this topic.
    Youu realize so much iits almost hard to argue with you (not that
    I personally wkuld want to…HaHa). You
    definitely put a new spin oon a topic that’s been discussed for ages.
    Wonderful stuff, just great!

    Here is mmy web-site- laser hair removal

  7. kyleshores6871.wikidot.com Says:

    kyleshores6871.wikidot.com

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  8. Read Full Report Says:

    Read Full Report

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  9. Noel Sasseville Says:

    Noel Sasseville

    I found a great…

  10. Chara Abdula Says:

    Chara Abdula

    I found a great…

  11. Lael Selem Says:

    Lael Selem

    I found a great…

  12. Christopher Alcina Says:

    Christopher Alcina

    I found a great…

  13. Loris Boehme Says:

    Loris Boehme

    I found a great…

  14. Aurelio Says:

    Have you ever thought about publishing an ebook or guest authoring on other websites?
    I have a blog based upon on the same topics you discuss and would love to have you share
    some stories/information. I know my audience would value your
    work. If you are even remotely interested, feel free to shoot me an e-mail.

Leave a Reply