Sheriffing@Mozilla – Sheriffing and Backouts

April 3rd, 2017 by cbook

Hi,

Keeping the code trees [1] green (meaning free of build or test failures,
regressions, and minimizing intermittent test failures) is the daily
goal of sheriffing.

In order to reach this goal, this means we sometimes have to back out (revert)
changes made by developers. While this is a part of our job, we don’t do
it easily or without reason.

Backouts happen mostly for:
-> Bustage (i.e. Firefox no longer
successfully builds)
-> Test failures caused by a specific change
-> Issues reported by the community, like startup crashes or severe
regressions (these backouts often lead to new nightly builds being
created as well)
-> Performance regressions or memory leaks
-> Issues that block merges like merge-conflicts (like for a mozilla-inbound to mozilla-central merge)

For our primary integration repositories (where our developers land most
their changes), our workflow depends on which repository the problem is
on.

Mozilla-Inbound

-> Close Mozilla-Inbound if needed (preventing
developers from landing any further changes until the problem is
resolved)

-> Try to notify the responsible developer so that they
areĀ  aware of the problem caused by their patch

-> If possible, we
accept follow-up patches to fix the problem. This allows us to fail
forward and avoid running extra jobs that require more CPU time and
therefore increase costs.

-> If we don’t get response from the developer within a short
timeframe like 5 minutes, we back out the change and comment in the
bug with a reason for the backout (for example, including a link to the
failure log) and a needinfo to the assigne, to make sure the bug don’t get lost.

Autoland

-> Changesets that cause problems are backed out immediately –
no follow-ups as described above are possible (only the sheriffs can push manually to
autoland)

In any case, backouts are never meant to be personal and it’s part of
our job to try our best to keep our trees open for developers. We also
try to provide as much information as possible in the bug for why we
backed out a change.

Of course, we also make mistakes and it could be that we backed out
changesets that were innocent (like in a case where its not 100% clear
what caused the problem), but we try our best.

If you feedback or ideas how we can make things better, let me know.

Cheers,
– Tomcat

 

[1] Trees: The tree contains the source code as well as the code required to build each project on supported platforms (Linux, Windows, macOS, etc) and tests for various areas. Sheriffs take care of Firefox Code Trees like mozilla-central, mozilla-inbound, autoland, mozilla-aurora, mozilla-beta and mozilla-esr45/52 – our primary tool is treeherder and can be found here

672 Responses to “Sheriffing@Mozilla – Sheriffing and Backouts”

  1. Roseanne Prinzing Says:

    Roseanne Prinzing

    I found a great…

  2. Dale Perow Says:

    Dale Perow

    I found a great…

  3. for beginners Says:

    for beginners

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  4. Cheyenne Raisley Says:

    Cheyenne Raisley

    I found a great…

  5. Catherine Redler Says:

    Catherine Redler

    I found a great…

  6. commercial vehicle insurance truck Says:

    commercial vehicle insurance truck

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  7. discover credit report monitoring Says:

    discover credit report monitoring

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  8. cheap commercial truck insurance near me Says:

    cheap commercial truck insurance near me

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  9. best free identity theft protection Says:

    best free identity theft protection

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  10. Situs DominoQQ Terpercaya Says:

    She said smartphone performance means, for example, displaying incoming text
    messages from one’s smartphone on the tracker itself.

  11. Buy Best Private Proxy Says:

    Buy Best Private Proxy

    I found a great…

  12. Selling Proxies Says:

    Selling Proxies

    I found a great…

  13. Jamey Suda Says:

    Jamey Suda

    I found a great…

  14. buy proxy list cheap Says:

    buy proxy list cheap

    I found a great…

  15. ssl proxies blogspot Says:

    ssl proxies blogspot

    I found a great…

  16. buy private proxy sites Says:

    buy private proxy sites

    I found a great…

  17. Glady Pavlas Says:

    Glady Pavlas

    I found a great…

  18. Gerardo Houey Says:

    Gerardo Houey

    I found a great…

  19. Adan Swartz Says:

    Adan Swartz

    I found a great…

  20. average cost of box truck insurance Says:

    average cost of box truck insurance

    Tomcat's Blog » Blog Archive » Sheriffing@Mozilla – Sheriffing and Backouts

  21. Albert Kunimitsu Says:

    Albert Kunimitsu

    I found a great…

  22. Brandon Falzarano Says:

    Brandon Falzarano

    I found a great…

Leave a Reply