Mark Hammond recently started an etherpad about how people work with git. Rather than commenting there, I thought I’d blog about my workflow instead.
First piece: magit. If you use emacs and git, and you don’t use magit, you are missing out. Highly recommended. I don’t use the git command line for common operations anymore; I do everything through magit. magit’s interactive staging is a big improvement over git add -i: you can stage files, hunks, or individual regions selectable by normal Emacs point-and-mark. I also really like magit’s rebasing support, as I use rebase a lot.
Second piece: git-bz-moz. I was reluctant to use this at first, but it’s been a huge boon in posting patches directly from my editor. Setup is pretty straightforward; I have:
[bz] firefox-profile = other default-tracker = bugzilla.mozilla.org default-product = General default-component = Core default-assigned-to = nfroyd@mozilla.com add-url-method = subject-prepend:Bug %d -
in my ~/.gitconfig, and git-bz is smart enough to go grovel through my Firefox profile to get my Bugzilla login information. Having it auto-mark bugs with the appropriate bug numbers during export is also helpful. (It’s smart enough to remove them when adding descriptions for the patches in Bugzilla.) My only complaint is that attaching patches to a bug doesn’t auto-assign the bug to you, like like hg bzexport does.
Third piece: I wrote a script I call export-patches for sending stuff to try, committing to inbound, and exporting patches for uplift. (I used to use it for formatting patches for bugzilla, but stopped doing that after learning git-bz.) I can push things to try:
export-patches -h ${mc_repo} -t '-b do -p all -u all -t none' ${start}..${end}
or push things to inbound:
export-patches -h ${mi_repo} -r ehsan -b 1 -c ${start}..${end}
It supports per-patch reviewers, too (along with a couple of other things I won’t demonstrate here):
export-patches -h ${mi_repo} -r bz:glandium -b 1 -c ${start}..${end}
The -b 1 convention is leftover from when I wasn’t tagging my patches with bug numbers until commit. (The script complains if bug numbers aren’t specified on the command line for commits.) git-bz absolved me of doing that. I should probably fix that.
Third-and-a-half piece: export-patches takes some pains (not as many as it could) to ensure that whatever repo I’m using gets its patch queue wiped if things fail. Less monkeying around with mercurial commands is a win in my book.
Fourth piece: One big branch of work. I used to use separate branches for bugs. However, I found that I was working on enough things simultaneously that switching between branches, rebasing if necessary, clobbering if necessary (often), and so forth was just too disruptive for day-to-day stuff. I’ll use branches if I have really disruptive things that I can’t integrate piecemeal into my one big branch, but generally everything goes into one branch. I ensure things build locally and I make occasional efforts to ensure appropriate tests still work locally, but try is where most of my testing gets done nowadays.
Fourth-and-a-half piece: I never checkout master
. I always fetch origin
, and then rebase off of origin/master
. My branches all track origin/master
, so magit will tell me exactly what commits I have remaining to go upstream.
Annoyances: If I commit patches, then those patches get backed out, when I next pull from mozilla-central and rebase, the patches that I pushed disappear from my branch. I haven’t looked too deeply into why this happens, but I’d really like to fix that.